contracts/identity-registry-contract/src/test.rs (1)

51-77: Consider adding event verification.

The test correctly verifies that the URI is updated in storage. However, the comment on line 76 states that event assertion is skipped to avoid flakiness. If the event emission is an important part of the contract behavior (which it appears to be based on emit_profile_updated being called in update_profile), consider adding event verification similar to test_expert_status_changed_event.

💡 Optional: Add event verification

     // Assert record updated
     env.as_contract(&contract_id, || {
         let rec = storage::get_expert_record(&env, &expert);
         assert_eq!(rec.data_uri, uri2);
     });

-    // Event assertion skipped to avoid flakiness in event buffers
+    // Verify profile_updated event was emitted
+    let events = env.events().all();
+    let event = events.last().unwrap();
+    assert_eq!(event.0, contract_id);
+    let topic: Symbol = event.1.get(0).unwrap().try_into_val(&env).unwrap();
+    assert_eq!(topic, Symbol::new(&env, "profile_updated"));
 }

contracts/identity-registry-contract/src/contract.rs (2)

32-34: Hoist empty URI creation outside the loop.
Minor gas/alloc savings by creating once and cloning per iteration.

♻️ Suggested tweak

-    for expert in experts {
+    let empty_uri = String::from_str(&env, "");
+    for expert in experts {
         let status = storage::get_expert_status(&env, &expert);
         if status == ExpertStatus::Verified {
             return Err(RegistryError::AlreadyVerified);
         }
-        // Default empty URI for batch adds
-        let empty_uri = String::from_str(&env, "");
-        storage::set_expert_record(&env, &expert, ExpertStatus::Verified, empty_uri);
+        // Default empty URI for batch adds
+        storage::set_expert_record(&env, &expert, ExpertStatus::Verified, empty_uri.clone());
         events::emit_status_change(&env, expert, status, ExpertStatus::Verified, admin.clone());
     }

---

63-79: Centralize URI length limit and clarify that String::len() returns byte count, not character count.

Both verify_expert and update_profile duplicate the 64-byte check. Define a constant at the module level and use it in both functions to keep them in sync. Note: the current comment says "~64 chars" but soroban_sdk::String::len() returns the byte length of the underlying u8 array, so URIs with multi-byte UTF-8 characters may appear shorter in character count than the 64-byte limit.

♻️ Suggested refactor

+const MAX_URI_LEN: u32 = 64;
+
 pub fn verify_expert(env: &Env, expert: &Address, data_uri: String) -> Result<(), RegistryError> {
@@
-    if data_uri.len() > 64 {
+    if data_uri.len() > MAX_URI_LEN {
         return Err(RegistryError::UriTooLong);
     }
@@
 pub fn update_profile(env: &Env, expert: &Address, new_uri: String) -> Result<(), RegistryError> {
@@
-    if new_uri.len() > 64 {
+    if new_uri.len() > MAX_URI_LEN {
         return Err(RegistryError::UriTooLong);
     }